test(installer): migrate end-to-end tests to PlayWright#61883
Open
susnux wants to merge 1 commit into
Open
Conversation
susnux
added
3. to review
susnux
requested review from
Altahrim,
icewind1991,
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
CarlSchwan
approved these changes
Jul 9, 2026
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
pringelmann
reviewed
Jul 9, 2026
|
|
||
| await waitOnNextcloud(ip) | ||
| await configureNextcloud() | ||
| await configureNextcloud(process.env.PLAYWRIGHT_SETUP ? [] : ['viewer']) |
Contributor
There was a problem hiding this comment.
Is PLAYWRIGHT_SETUP meant to be set somewhere? Nothing seems to set it. Maybe the setup script? Or we maybe document that it exists in the testing readme?
Contributor
Author
There was a problem hiding this comment.
Ah yes should be set in the ci script so that we do not clone that.
Should reduce setup by a couple of seconds on CI - we do not need the viewer for setup tests.
pringelmann
approved these changes
Jul 9, 2026
pringelmann
left a comment
pringelmann
left a comment
Contributor
There was a problem hiding this comment.
🚀 Just one question on env var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated the installer tests from Cypress to PlayWright.
AI was used - reviewed their changes and adjusted manually.
Checklist
3. to review, feature component)stable32)AI (if applicable)